Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ADA-1751): [TR] ADA Loading play not announced #968

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Conversation

Tzipi-kaltura
Copy link
Contributor

@Tzipi-kaltura Tzipi-kaltura commented Dec 18, 2024

Description of the Changes

Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

Issue:
Screen reader user doesn't have indication on loading state.

Fix:
Adding hidden element that visible only to screen reader. in case loading take more than second, "loading" message will be announced.

Resolves ADA-1751

translations/en.i18n.json Show resolved Hide resolved
src/components/spinner/spinner.tsx Outdated Show resolved Hide resolved
src/components/spinner/_spinner.scss Show resolved Hide resolved
@Tzipi-kaltura Tzipi-kaltura merged commit 26f22f4 into master Dec 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants