Skip to content

Commit

Permalink
remove todos
Browse files Browse the repository at this point in the history
  • Loading branch information
SivanA-Kaltura committed Jun 6, 2024
1 parent 76da63b commit 1bb4791
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/engines/html5/html5.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1263,7 +1263,6 @@ export default class Html5 extends FakeEventTarget implements IEngine {

private _cachedUrls: string[] = [];

// TODO add to readme
public setCachedUrls(cachedUrls: string[]) {

Check warning on line 1266 in src/engines/html5/html5.ts

View workflow job for this annotation

GitHub Actions / lint / running-tests (ubuntu-latest)

Missing return type on function
this._cachedUrls = cachedUrls;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,5 @@ export default class BaseMediaSourceAdapter extends FakeEventTarget implements I
return null;
}

// // TODO add to readme
public setCachedUrls(cachedUrls: string[]) {}

Check warning on line 348 in src/engines/html5/media-source/base-media-source-adapter.ts

View workflow job for this annotation

GitHub Actions / lint / running-tests (ubuntu-latest)

Missing return type on function

Check failure on line 348 in src/engines/html5/media-source/base-media-source-adapter.ts

View workflow job for this annotation

GitHub Actions / lint / running-tests (ubuntu-latest)

'cachedUrls' is defined but never used
}
1 change: 0 additions & 1 deletion src/player.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2860,7 +2860,6 @@ export default class Player extends FakeEventTarget {

private _cachedUrls: string[] = [];

// TODO add to readme
public setCachedUrls(cachedUrls: string[]) {

Check warning on line 2863 in src/player.ts

View workflow job for this annotation

GitHub Actions / lint / running-tests (ubuntu-latest)

Missing return type on function
this._cachedUrls = cachedUrls;

Expand Down

0 comments on commit 1bb4791

Please sign in to comment.