Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SUP-37490): Align captions with clipTo/SeekFrom Values in PlayManifest #798

Merged
merged 3 commits into from
Nov 11, 2024
Merged

fix(SUP-37490): Align captions with clipTo/SeekFrom Values in PlayManifest #798

merged 3 commits into from
Nov 11, 2024

Conversation

SivanA-Kaltura
Copy link
Contributor

@SivanA-Kaltura SivanA-Kaltura commented Nov 10, 2024 •
edited
Loading

Description of the Changes

  • Add a new API for the player to set [seekFrom, clipTo] values

If seekFrom or clipTo are set

  • Filter caption cues outside the [seekFrom, clipTo] range
  • Translate the cues within the [seekFrom, clipTo] range into a time range that starts from 0

Related PR: kaltura/kaltura-player-js#876

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@SivanA-Kaltura SivanA-Kaltura changed the title add clip captions fix(SUP-37490): Align captions with clipTo/SeekFrom Values in PlayManifest Nov 10, 2024
@SivanA-Kaltura SivanA-Kaltura mentioned this pull request Nov 10, 2024
Merged
semarche-kaltura
semarche-kaltura requested changes Nov 11, 2024
View reviewed changes
src/track/external-captions-handler.ts Outdated Show resolved Hide resolved
src/track/external-captions-handler.ts Outdated Show resolved Hide resolved
lianbenjamin
lianbenjamin previously approved these changes Nov 11, 2024
View reviewed changes
@SivanA-Kaltura SivanA-Kaltura merged commit 8f24f03 into master Nov 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semarche-kaltura semarche-kaltura semarche-kaltura approved these changes

@lianbenjamin lianbenjamin lianbenjamin left review comments

@MosheMaorKaltura MosheMaorKaltura Awaiting requested review from MosheMaorKaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SivanA-Kaltura @semarche-kaltura @lianbenjamin