メッセージをタイムラインに追加（挿入）する際にうまくいかないのを修正

[kamecha]

メッセージ編集を適用する際に、元メッセージが削除されず、追記する形になっていた。
ただ、編集適用時に:bdeleteでウィンドウが閉じ、それに伴いdraw_recursiveが走ってうまく表示されていてしまった。

そのため、メッセージを編集する際は

1. 元メッセージを削除＆position再計算
2. メッセージを挿入&position再計算

が走るようにした。
その後にdraw_recursiveが走り、無駄な計算が走るが、これはこのPRの責務じゃないので無視

また、draw関連のposition、index周りが既存のvim関数と似ておらず混乱するので、indexや描画インターフェースを改善するのも今後しておきたい

Comments and Refactoring:

• autoload/traqvim/view.vim: Added several TODO comments to indicate areas for future improvements and refactoring. [1] [2] [3] [4]

Function Modifications:

• autoload/traqvim/view.vim: Renamed the function traqvim#view#draw_insert_message to traqvim#view#draw_append_message and updated its logic to handle message positions differently.

Timeline Management:

• denops/traqvim/action.ts: Updated the actionEditMessage function to delete and append messages in the channelTimeline buffer variable. [1] [2]

Summary by CodeRabbit

• New Features

  • Improved message handling in timelines, including better rendering and position management for edited and pinned messages.
  • Enhanced clarity in message display with updated logic for appending messages.

• Bug Fixes

  • Resolved issues with message rendering after edits and deletions, ensuring accurate timeline representation.

• Documentation

  • Translated comments from Japanese to English for better accessibility and understanding.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to the autoload/traqvim/view.vim and denops/traqvim/action.ts files, focusing on message rendering and position management within a timeline. Key changes include renaming the function for drawing messages, updating logic for message positioning, and enhancing the handling of pinned messages. Additionally, the actionEditMessage function now filters edited messages before appending updates, and several function signatures have been updated to include return types for clarity.

Changes

File Path	Change Summary
autoload/traqvim/view.vim	- Renamed draw_insert_message to draw_append_message. - Updated logic for message positioning. - Minor adjustments to pinned message handling. - Added comments in Japanese for future improvements.
denops/traqvim/action.ts	- Modified actionEditMessage to filter and append edited messages. - Updated function signatures to include return types. - Translated comments from Japanese to English for clarity. - Ensured correct reflection of pinned message status in the timeline.

Possibly related PRs

• 現状のなんちゃってアーキテクチャは温存したままvim側のファイルとかを整理 #87: This PR modifies the traqvim#view#draw_insert_message function, which is directly related to the renaming of traqvim#view#draw_insert_message to traqvim#view#draw_append_message in the main PR, indicating a strong connection in functionality.
• 前後のmessageを更新しようとすると、型チェックで落ちるのを修正 #96: The changes in this PR enhance the handling of messages, which aligns with the main PR's focus on improving message rendering and position management.
• メッセージに応じたチャンネルを開けるようにした #99: This PR introduces a new function for navigating to messages, which relates to the overall improvements in message handling and rendering in the main PR.
• 引用メッセージから元メッセージへ飛べるようにした #102: The modifications in this PR to the goto_message function and its integration with quoted messages connect to the main PR's focus on message rendering and management.
• メッセージについてるスタンプを表示 #104: This PR enhances the make_message_body function to include stamps, which is relevant to the main PR's changes in message body creation and rendering.

Suggested labels

enhancement

Poem

🐰 In the burrow where messages flow,
New ways to append, now watch them grow!
Pinned with care, they stand so bright,
A timeline of tales, a wondrous sight.
Hopping along, with joy we sing,
For each little change, a happy spring! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.