Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

それっぽいdduのcolumnを追加 #74

Merged
merged 6 commits into from
Dec 22, 2023
Merged

それっぽいdduのcolumnを追加 #74

merged 6 commits into from
Dec 22, 2023

Conversation

kamecha
Copy link
Owner

@kamecha kamecha commented Dec 22, 2023

  • dduのカラムのテンプレを追加
  • それぞれのチャンネル用のアイコンをParamとして設定

Summary by CodeRabbit

  • New Features
    • Introduced a new column display feature with customization options for icons and indentation.
  • Enhancements
    • Integrated new column functionality from an external module for improved user interface components.

Copy link

coderabbitai bot commented Dec 22, 2023

Walkthrough

The update involves the introduction of a new Column class in a file, providing functionality for handling column attributes such as length, text, icons, and indentation. Additionally, there's an update to a dependency file that now exports a dduVimColumn from a Deno module, expanding the module's public interface.

Changes

File Path Change Summary
.../@ddu-columns/channel.ts
.../@ddu-sources/channel.ts
Introduced Column class, Params type, and modified logic for constructing word property.
.../traqvim/deps.ts Added new export dduVimColumn from "https://deno.land/x/ddu_vim@v1.13.0/base/column.ts".

🐰✨
In the realm of code, where changes abound,
A new class sprouts, from the digital ground.
With a hop and a skip, exports align,
Our codebase grows, ever so fine. 🌱
🎉🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions. Examples:
    • @coderabbitai render interesting statistics about this repository as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai generate unit tests for the src/utils.ts file.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@kamecha kamecha marked this pull request as draft December 22, 2023 06:27
@kamecha kamecha self-assigned this Dec 22, 2023
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8d444b9 and 04db327.
Files selected for processing (2)
  • denops/@ddu-columns/channel.ts (1 hunks)
  • denops/traqvim/deps.ts (1 hunks)
Additional comments: 3
denops/@ddu-columns/channel.ts (2)
  • 3-8: The Params type is well-defined with clear parameter names and types. Ensure that the icons and indentation width are consistent with the UI design guidelines.

  • 19-25: The params method correctly returns default values for the parameters. Verify that these defaults align with the intended default behavior of the columns.

denops/traqvim/deps.ts (1)
  • 19-19: The export of dduVimColumn is correctly added. Ensure that any documentation or consumers of this module are updated to reflect the availability of this new entity.

Comment on lines 11 to 12
getLength({}: dduVimColumn.GetLengthArguments<Params>): Promise<number> {
throw new Error("Method not implemented.");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getLength method is not implemented and throws an error. If this is intentional, consider adding a TODO comment or implementing the method before merging.

Comment on lines 14 to 17
getText(
{}: dduVimColumn.GetTextArguments<Params>,
): Promise<dduVimColumn.GetTextResult> {
throw new Error("Method not implemented.");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the getText method is not implemented. Ensure to either implement it or mark it with a TODO for future implementation.

@kamecha kamecha linked an issue Dec 22, 2023 that may be closed by this pull request
@kamecha kamecha marked this pull request as ready for review December 22, 2023 09:26
@kamecha kamecha merged commit ba97280 into master Dec 22, 2023
1 check passed
@kamecha kamecha deleted the feature/ddu-column branch December 22, 2023 09:26
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 04db327 and 8c22248.
Files selected for processing (2)
  • denops/@ddu-columns/channel.ts (1 hunks)
  • denops/@ddu-sources/channel.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • denops/@ddu-columns/channel.ts
Additional comments: 2
denops/@ddu-sources/channel.ts (2)
  • 38-44: The change simplifies the assignment of the word property by using channel.name directly. This is a logical simplification if channel.name always represents the desired string for word. Ensure that this change does not affect any functionality that relied on the previous structure of word.

  • 63-69: Similar to the first hunk, this change simplifies the word property assignment for childrenChannel. Verify that childrenChannel.name contains the correct value for word and that no features depend on the previous path-based logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

traQに沿ったddu-columnの作成
1 participant