-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
それっぽいdduのcolumnを追加 #74
Conversation
WalkthroughThe update involves the introduction of a new Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (2)
- denops/@ddu-columns/channel.ts (1 hunks)
- denops/traqvim/deps.ts (1 hunks)
Additional comments: 3
denops/@ddu-columns/channel.ts (2)
3-8: The
Params
type is well-defined with clear parameter names and types. Ensure that the icons and indentation width are consistent with the UI design guidelines.19-25: The
params
method correctly returns default values for the parameters. Verify that these defaults align with the intended default behavior of the columns.denops/traqvim/deps.ts (1)
- 19-19: The export of
dduVimColumn
is correctly added. Ensure that any documentation or consumers of this module are updated to reflect the availability of this new entity.
denops/@ddu-columns/channel.ts
Outdated
getLength({}: dduVimColumn.GetLengthArguments<Params>): Promise<number> { | ||
throw new Error("Method not implemented."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The getLength
method is not implemented and throws an error. If this is intentional, consider adding a TODO
comment or implementing the method before merging.
denops/@ddu-columns/channel.ts
Outdated
getText( | ||
{}: dduVimColumn.GetTextArguments<Params>, | ||
): Promise<dduVimColumn.GetTextResult> { | ||
throw new Error("Method not implemented."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, the getText
method is not implemented. Ensure to either implement it or mark it with a TODO
for future implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- denops/@ddu-columns/channel.ts (1 hunks)
- denops/@ddu-sources/channel.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- denops/@ddu-columns/channel.ts
Additional comments: 2
denops/@ddu-sources/channel.ts (2)
38-44: The change simplifies the assignment of the
word
property by usingchannel.name
directly. This is a logical simplification ifchannel.name
always represents the desired string forword
. Ensure that this change does not affect any functionality that relied on the previous structure ofword
.63-69: Similar to the first hunk, this change simplifies the
word
property assignment forchildrenChannel
. Verify thatchildrenChannel.name
contains the correct value forword
and that no features depend on the previouspath
-based logic.
Summary by CodeRabbit