Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

サブコマンドを使って名前空間を侵さないようにした #82

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

kamecha
Copy link
Owner

@kamecha kamecha commented Jul 7, 2024

https://github.com/nvim-neorocks/nvim-best-practices#speaking_head-user-commands

ここに書かれてるみたく
:TraqMessageOpen :TraqMessageSendみたいなのを

:Traq message open :Traq message sendみたくできるようにした

ただ、なんちゃって実装&既存の状態のディレクトリ分け等がもともと汚い
ってのもあって大幅修正する必要あり

Summary by CodeRabbit

  • New Features

    • Introduced command functionality for managing OAuth tokens, channels, activities, messages, and pins within the traqvim service.
    • Added command completion feature for easier command execution.
  • Refactor

    • Unified multiple individual commands into a single versatile Traq command with flexible argument handling for various operations.
  • Removals

    • Removed specific command declarations for yanking message links and markdown in traqvim.

Copy link

coderabbitai bot commented Jul 7, 2024

Walkthrough

The updates unify and expand the command-handling capabilities related to the traqvim service. Key functionalities include OAuth token management, channel interactions, activity, message, and pin operations, all consolidated into a single Traq command with flexible argument handling and enhanced command completion.

Changes

File Change Summary
autoload/command.vim Added s:subcommands. Enhanced functions for token, channel, activity, message, and pin management. Improved command completion and parsing.
ftplugin/traqvim.vim Removed commands for yanking message links and markdown. Retained filetype and window size actions.
plugin/traqvim.vim Consolidated multiple Traq related commands into a single flexible Traq command.

Poem

In the code, new paths unfurl,
Traq commands now in a twirl.
Channels, pins, and tokens bright,
All in one command's might.
Completion swift, the lines align,
With traqvim, your Vim will shine! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kamecha
Copy link
Owner Author

kamecha commented Jul 7, 2024

Close #80

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ac5b55f and 04fd182.

Files selected for processing (3)
  • autoload/command.vim (1 hunks)
  • ftplugin/traqvim.vim (1 hunks)
  • plugin/traqvim.vim (1 hunks)
Files skipped from review due to trivial changes (1)
  • ftplugin/traqvim.vim
Additional comments not posted (11)
plugin/traqvim.vim (3)

6-10: LGTM! The command definition is correct.

The Traq command is correctly defined with custom completion and calls command#call.


Line range hint 12-16:
LGTM! The setup code is correct.

The global variables and the autocommand group are correctly defined.


Line range hint 18-22:
LGTM! The autocommand group is correctly defined.

The autocommand group handles buffer events and calls traqvim#draw_timeline.

autoload/command.vim (8)

2-8: LGTM! The dictionary for command completions is correctly defined.

The dictionary s:completions accurately stores the command completions.


10-16: LGTM! The function command#token is correctly implemented.

The function correctly handles the setup and deletion of OAuth tokens using denops#request.


18-31: LGTM! The function command#channel is correctly implemented.

The function correctly handles various channel interactions using denops#request.


33-39: LGTM! The function command#activity is correctly implemented.

The function correctly handles various activity management tasks using denops#request.


41-57: LGTM! The function command#message is correctly implemented.

The function correctly handles various message operations using denops#request.


59-65: LGTM! The function command#pin is correctly implemented.

The function correctly handles pin creation and removal using denops#request.


67-84: LGTM! The function command#complete is correctly implemented.

The function correctly handles the command completion logic.


86-91: LGTM! The function command#call is correctly implemented.

The function correctly handles the command parsing and execution.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 04fd182 and c69c781.

Files selected for processing (1)
  • autoload/command.vim (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • autoload/command.vim

@kamecha kamecha merged commit ed398bb into master Jul 11, 2024
1 check passed
@kamecha kamecha deleted the refacter/use-subcommand branch July 11, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant