-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
サブコマンドを使って名前空間を侵さないようにした #82
Conversation
WalkthroughThe updates unify and expand the command-handling capabilities related to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Close #80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- autoload/command.vim (1 hunks)
- ftplugin/traqvim.vim (1 hunks)
- plugin/traqvim.vim (1 hunks)
Files skipped from review due to trivial changes (1)
- ftplugin/traqvim.vim
Additional comments not posted (11)
plugin/traqvim.vim (3)
6-10
: LGTM! The command definition is correct.The
Traq
command is correctly defined with custom completion and callscommand#call
.
Line range hint
12-16
:
LGTM! The setup code is correct.The global variables and the autocommand group are correctly defined.
Line range hint
18-22
:
LGTM! The autocommand group is correctly defined.The autocommand group handles buffer events and calls
traqvim#draw_timeline
.autoload/command.vim (8)
2-8
: LGTM! The dictionary for command completions is correctly defined.The dictionary
s:completions
accurately stores the command completions.
10-16
: LGTM! The functioncommand#token
is correctly implemented.The function correctly handles the setup and deletion of OAuth tokens using
denops#request
.
18-31
: LGTM! The functioncommand#channel
is correctly implemented.The function correctly handles various channel interactions using
denops#request
.
33-39
: LGTM! The functioncommand#activity
is correctly implemented.The function correctly handles various activity management tasks using
denops#request
.
41-57
: LGTM! The functioncommand#message
is correctly implemented.The function correctly handles various message operations using
denops#request
.
59-65
: LGTM! The functioncommand#pin
is correctly implemented.The function correctly handles pin creation and removal using
denops#request
.
67-84
: LGTM! The functioncommand#complete
is correctly implemented.The function correctly handles the command completion logic.
86-91
: LGTM! The functioncommand#call
is correctly implemented.The function correctly handles the command parsing and execution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- autoload/command.vim (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- autoload/command.vim
https://github.com/nvim-neorocks/nvim-best-practices#speaking_head-user-commands
ここに書かれてるみたく
:TraqMessageOpen
:TraqMessageSend
みたいなのを:Traq message open
:Traq message send
みたくできるようにしたただ、なんちゃって実装&既存の状態のディレクトリ分け等がもともと汚い
ってのもあって大幅修正する必要あり
Summary by CodeRabbit
New Features
traqvim
service.Refactor
Traq
command with flexible argument handling for various operations.Removals
traqvim
.