Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ログイン/登録ページのコンポーネント分割と、登録ページのテストを作成 #26

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

kameiryohei
Copy link
Owner

@kameiryohei kameiryohei commented Oct 11, 2024

実装意図

  • コンポーネント分割における統一性がない #12 にあるようにアプリケーション全体でコンポーネント分割が適切ではないためリファクタリング
  • また、登録ページのテストケースはログインと重複している箇所が多いため、簡単に作成

実装内容

  • /app/user/login or /registerではformタグを切り出してそれぞれLoginForm,tsxRegisterForm.tsxを作成
  • また、テストはRegisterPage.test.tsxを作成し、ログインのテストとほぼ同じテストを作成

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
class-planner ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 9:22am

@kameiryohei kameiryohei merged commit 9ca22cb into main Oct 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant