Fix test failure in MagicSchedulerTest post improvements (again)

kamil-sita · Jun 8, 2024 · 6d177e4 · 6d177e4
1 parent 12aadd1
commit 6d177e4
Showing 1 changed file with 3 additions and 14 deletions.
diff --git a/magic-scheduler/src/test/java/place/sita/magicscheduler/scheduler/MagicSchedulerTest.java b/magic-scheduler/src/test/java/place/sita/magicscheduler/scheduler/MagicSchedulerTest.java
@@ -18,16 +18,12 @@
 import java.time.LocalDateTime;
 import java.time.OffsetDateTime;
 import java.time.temporal.ChronoUnit;
-import java.util.UUID;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.*;
 
 public class MagicSchedulerTest extends TestContainersTest {
 
-	@Autowired
-	private MagicScheduler magicScheduler;
-
 	@Autowired
 	private StringTestTask stringTestTask;
 
@@ -53,10 +49,9 @@ public void shouldRunTask() {
 		when(stringTaskTestValueProcessor.process(any(), any())).thenReturn(TaskResult.success("Success: test"));
 
 		// when
-		runTasksAsTest(stringTestTask, "test", 0, callback);
+		runTasksAsTest(stringTestTask, "test");
 
 		// then
-		verify(callback, never()).onExecutionFinished();
 		var tasksBefore = executionsService.getScheduledTasks(Integer.MAX_VALUE, 0, null);
 		assertThat(tasksBefore).hasSize(1);
 		assertThat(tasksBefore.get(0).taskCode()).isEqualTo(stringTestTask.code());
@@ -71,7 +66,6 @@ public void shouldRunTask() {
 		argumentCaptor.getValue().run();
 
 		// then
-		verify(callback).onExecutionFinished();
 		var tasksAfter = executionsService.getScheduledTasks(Integer.MAX_VALUE, 0, null);
 		assertThat(tasksAfter).hasSize(1);
 		assertThat(tasksAfter.get(0).taskCode()).isEqualTo(stringTestTask.code());
@@ -88,17 +82,12 @@ public void shouldRunTask() {
 		// todo test return value
 	}
 
-	private <ParameterT> void runTasksAsTest(TaskType<ParameterT, ?, ?> taskType,
-	                                         ParameterT parameter,
-	                                         int executionCount,
-	                                         MagicScheduler.ExecutionFinishedCallback callback) {
-		UUID id;
+	private <ParameterT> void runTasksAsTest(TaskType<ParameterT, ?, ?> taskType, ParameterT parameter) {
 		try {
-			id = internalTaskSubmitter.submitTaskForLater(taskType.code(), new ObjectMapper().writeValueAsString(parameter), InternalTaskSubmitter.UUID_FOR_USER_SUBMITTED_TASKS);
+			internalTaskSubmitter.submitTaskForLater(taskType.code(), new ObjectMapper().writeValueAsString(parameter), InternalTaskSubmitter.UUID_FOR_USER_SUBMITTED_TASKS);
 		} catch (JsonProcessingException e) {
 			throw new RuntimeException(e);
 		}
-		magicScheduler.schedule(id, taskType, parameter, executionCount, callback);
 	}
 
 }