Flex CLI deployment config changes. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khkh-ms
commented
Feb 16, 2024
| functionapp = client.web_apps.get(resource_group_name, name) | ||
| if deployment_storage_auth_type == 'UserAssignedIdentity': | ||
| assign_identity(cmd, resource_group_name, name, assign_identities) | ||
| if (_has_deployment_storage_role_assignment_on_resource(cmd.cli_ctx, deployment_storage, |
There was a problem hiding this comment.
I think the create flow may also need this check.
kamperiadis
requested changes
Feb 16, 2024
| @@ -793,6 +793,12 @@ def load_arguments(self, _): | |||
| c.argument('deployment_storage_container_name', help="The deployment storage account container name.", is_preview=True) | |||
| c.argument('deployment_storage_auth_type', arg_type=get_enum_type(DEPLOYMENT_STORAGE_AUTH_TYPES), help="The deployment storage account authentication type.", is_preview=True) | |||
| c.argument('deployment_storage_auth_value', help="The deployment storage account authentication value. This is only applicable for the user-assigned managed identity authentication type.", is_preview=True) | |||
|
|
|||
| with self.argument_context('az functionapp deployment config set') as c: | |||
| deployment_storage_container_name = deployment_storage_container.name | ||
| deployment_config_storage_value = getattr(deployment_storage.primary_endpoints, 'blob') + deployment_storage_container_name | ||
| functionapp_deployment_storage["value"] = deployment_config_storage_value | ||
| functionapp_deployment_storage["type"] = "blobContainer" |
There was a problem hiding this comment.
I don't think we need this line to set the type since we will always have this 'blobContainer' type. I would just remove it.
| functionapp_deployment_storage["authentication"]["userAssignedIdentityResourceId"] = None | ||
| functionapp_deployment_storage["authentication"]["storageAccountConnectionStringName"] = None | ||
| elif deployment_storage_auth_type == 'UserAssignedIdentity': | ||
| assign_identities = [deployment_storage_auth_value] |
There was a problem hiding this comment.
I would remove this line since L1651 already sets this variable after the user assigned identity is validated
kamperiadis
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.