Skip to content

Fixes for IE 8 compatibility #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes for IE 8 compatibility #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82d45eb
Fixes for IE 8 compatibility
Jun 27, 2018
cc49344
Refinements since minification strips quotes from JSON keys
Jun 27, 2018
4607ec2
Fix a typo in the demo source code
Jun 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions demos/js/jquery.toast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@ if ( typeof Object.create !== 'function' ) {

var _toastContent = '';

this._toastEl = this._toastEl || $('<div></div>', {
class : 'jq-toast-single'
});
this._toastEl = this._toastEl || $('<div class="jq-toast-single"></div>');

// For the loader on top
_toastContent += '<span class="jq-toast-loader"></span>';
Expand Down Expand Up @@ -95,8 +93,8 @@ if ( typeof Object.create !== 'function' ) {
};
};

if ( this.options.class !== false ){
this._toastEl.addClass(this.options.class)
if ( this.options.htmlClass !== false ){
this._toastEl.addClass(this.options.htmlClass)
}
},

Expand Down Expand Up @@ -195,11 +193,7 @@ if ( typeof Object.create !== 'function' ) {

if ( _container.length === 0 ) {

_container = $('<div></div>',{
class: "jq-toast-wrap",
role: "alert",
"aria-live": "polite"
});
_container = $('<div class="jq-toast-wrap" role="alert" aria-live="polite"></div>');

$('body').append( _container );

Expand Down
2 changes: 1 addition & 1 deletion dist/jquery.toast.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 4 additions & 10 deletions src/jquery.toast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@ if ( typeof Object.create !== 'function' ) {

var _toastContent = '';

this._toastEl = this._toastEl || $('<div></div>', {
class : 'jq-toast-single'
});
this._toastEl = this._toastEl || $('<div class="jq-toast-single"></div>');

// For the loader on top
_toastContent += '<span class="jq-toast-loader"></span>';
Expand Down Expand Up @@ -95,8 +93,8 @@ if ( typeof Object.create !== 'function' ) {
};
};

if ( this.options.class !== false ){
this._toastEl.addClass(this.options.class)
if ( this.options.htmlClass !== false ){
this._toastEl.addClass(this.options.htmlClass)
}
},

Expand Down Expand Up @@ -201,11 +199,7 @@ if ( typeof Object.create !== 'function' ) {

if ( _container.length === 0 ) {

_container = $('<div></div>',{
class: "jq-toast-wrap",
role: "alert",
"aria-live": "polite"
});
_container = $('<div class="jq-toast-wrap" role="alert" aria-live="polite"></div>');

$('body').append( _container );

Expand Down