Skip to content

Commit

Permalink
Revert check
Browse files Browse the repository at this point in the history
  • Loading branch information
@rmn-boiko
rmn-boiko committed Oct 11, 2024
1 parent 27838ef commit f48972a
Show file tree
Hide file tree
Showing 3 changed files with 56 additions and 46 deletions.
16 changes: 13 additions & 3 deletions src/e2e/app/cli/common/src/kamu_api_server_client_ext.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,20 +57,30 @@ pub const DATASET_DERIVATIVE_LEADERBOARD_SNAPSHOT_STR: &str = indoc::indoc!(
alias: player_scores
transform:
kind: Sql
engine: flink
engine: risingwave
queries:
- query: |
- alias: leaderboard
# Note we are using explicit `crate materialized view` statement below
# because RW does not currently support Top-N queries directly on sinks.
#
# Note `partition by 1` is currently required by RW engine
# See: https://docs.risingwave.com/docs/current/window-functions/#syntax
query: |
create materialized view leaderboard as
select
*
from (
select
row_number() over (partition by 1 order by score desc) as place,
match_time,
match_id,
player_id,
score
from player_scores
)
where score > 90
where place <= 2
- query: |
select * from leaderboard
- kind: SetVocab
eventTimeColumn: match_time
"#
Expand Down
6 changes: 3 additions & 3 deletions src/e2e/app/cli/inmem/tests/tests/test_smart_transfer_protocol.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ kamu_cli_run_api_server_e2e_test!(
options = Options::default()
.with_multi_tenant()
.with_today_as_frozen_system_time(),
extra_test_groups = "engine, ingest, datafusion"
extra_test_groups = "engine, ingest, transform, datafusion"
);

////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
Expand All @@ -75,7 +75,7 @@ kamu_cli_run_api_server_e2e_test!(
options = Options::default()
.with_multi_tenant()
.with_today_as_frozen_system_time(),
extra_test_groups = "engine, ingest, datafusion"
extra_test_groups = "engine, ingest, transform, datafusion"
);

////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
Expand All @@ -90,7 +90,7 @@ kamu_cli_execute_command_e2e_test!(
kamu_cli_execute_command_e2e_test!(
storage = inmem,
fixture = kamu_cli_e2e_repo_tests::test_smart_pull_reset_derivative,
extra_test_groups = "engine, ingest, datafusion"
extra_test_groups = "engine, ingest, transform, datafusion"
);

////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
Expand Down
80 changes: 40 additions & 40 deletions src/e2e/app/cli/repo-tests/src/test_smart_transfer_protocol.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -616,13 +616,13 @@ pub async fn test_smart_push_pull_all(kamu_api_server_client: KamuApiServerClien
kamu_in_pull_workspace
.assert_last_data_slice(&dataset_name, expected_schema, expected_data)
.await;
// kamu_in_pull_workspace
// .assert_last_data_slice(
// &dataset_derivative_name,
// expected_derivative_schema,
// expected_derivative_data,
// )
// .await;
kamu_in_pull_workspace
.assert_last_data_slice(
&dataset_derivative_name,
expected_derivative_schema,
expected_derivative_data,
)
.await;

// Update remote datasets
let data = indoc::indoc!(
Expand Down Expand Up @@ -687,13 +687,13 @@ pub async fn test_smart_push_pull_all(kamu_api_server_client: KamuApiServerClien
kamu_in_pull_workspace
.assert_last_data_slice(&dataset_name, expected_schema, expected_data)
.await;
// kamu_in_pull_workspace
// .assert_last_data_slice(
// &dataset_derivative_name,
// expected_derivative_schema,
// expected_derivative_data,
// )
// .await;
kamu_in_pull_workspace
.assert_last_data_slice(
&dataset_derivative_name,
expected_derivative_schema,
expected_derivative_data,
)
.await;
}
}

Expand Down Expand Up @@ -855,13 +855,13 @@ pub async fn test_smart_push_pull_recursive(kamu_api_server_client: KamuApiServe
kamu_in_pull_workspace
.assert_last_data_slice(&dataset_name, expected_schema, expected_data)
.await;
// kamu_in_pull_workspace
// .assert_last_data_slice(
// &dataset_derivative_name,
// expected_derivative_schema,
// expected_derivative_data,
// )
// .await;
kamu_in_pull_workspace
.assert_last_data_slice(
&dataset_derivative_name,
expected_derivative_schema,
expected_derivative_data,
)
.await;

// Update remote datasets
let data = indoc::indoc!(
Expand Down Expand Up @@ -913,13 +913,13 @@ pub async fn test_smart_push_pull_recursive(kamu_api_server_client: KamuApiServe
kamu_in_pull_workspace
.assert_last_data_slice(&dataset_name, expected_schema, expected_data)
.await;
// kamu_in_pull_workspace
// .assert_last_data_slice(
// &dataset_derivative_name,
// expected_derivative_schema,
// expected_derivative_data,
// )
// .await;
kamu_in_pull_workspace
.assert_last_data_slice(
&dataset_derivative_name,
expected_derivative_schema,
expected_derivative_data,
)
.await;
}
}

Expand Down Expand Up @@ -1004,12 +1004,12 @@ pub async fn test_smart_pull_reset_derivative(mut kamu: KamuCliPuppet) {
+--------+----+----------------------+----------------------+-------+----------+-----------+-------+
"#
);
// kamu.assert_last_data_slice(
// &dataset_derivative_name,
// expected_derivative_schema,
// expected_derivative_data,
// )
// .await;
kamu.assert_last_data_slice(
&dataset_derivative_name,
expected_derivative_schema,
expected_derivative_data,
)
.await;

// Compact root dataset
kamu.execute([
Expand Down Expand Up @@ -1054,12 +1054,12 @@ pub async fn test_smart_pull_reset_derivative(mut kamu: KamuCliPuppet) {
+--------+----+----------------------+----------------------+-------+----------+-----------+-------+
"#
);
// kamu.assert_last_data_slice(
// &dataset_derivative_name,
// expected_derivative_schema,
// expected_derivative_data,
// )
// .await;
kamu.assert_last_data_slice(
&dataset_derivative_name,
expected_derivative_schema,
expected_derivative_data,
)
.await;
}

////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
Expand Down

0 comments on commit f48972a

Please sign in to comment.