Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mal: error reporting, procedural env_set, native macro? #607

Merged
merged 11 commits into from
Aug 7, 2024

Conversation

asarhaddon
Copy link
Contributor

Hello.
This merge request contains 3 commits implementing three ideas, and a backport from #592. The suggestions are interconnected, so a single merge request is convenient for now to start discussion and list implementations for which apply refuses macros.

@asarhaddon
Copy link
Contributor Author

elm fails because the Docker image needs to be updated (#608), but Types.elm suggests that Core.elm/apply accepts macros.
Implementations for which core/apply refuses macro arguments:
erlang fsharp haskell nasm prolog sml vimscript
#592 should probably be completed first in order to avoid non-trivial rebase work.

@asarhaddon
Copy link
Contributor Author

I have rebased on #592 because rebasing was a nightmare.
Apparently, all failures related to this merge request are fixed.

@kanaka kanaka merged commit 3f6a40f into kanaka:master Aug 7, 2024
110 of 111 checks passed
@kanaka
Copy link
Owner

kanaka commented Aug 7, 2024

Looks good. Definitely good to have (apply macro ...) working for all implementations. Regarding the mal error checking, I've been torn between adding those or keeping the mal implementation as concise as possible. There are pedagogical reasons for both approaches. But I think I prefer error checking now.
Thanks!

@asarhaddon asarhaddon deleted the mal-impl branch August 7, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants