-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge eval and evalAST in purescript implementation #631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!!
93803f8
to
1717a2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the Dockerfile needs to be updated. Probably something like this:
FROM ubuntu:24.04
##########################################################
# General requirements for testing or common across many
# implementations
##########################################################
RUN apt-get -y update
# Required for running tests
RUN apt-get -y install make python3
RUN ln -fs /usr/bin/python3 /usr/local/bin/python
RUN mkdir -p /mal
WORKDIR /mal
##########################################################
# Specific implementation requirements
##########################################################
RUN DEBIAN_FRONTEND=noninteractive apt-get -y install g++ libreadline-dev nodej
s npm
# Install purescript and deps
RUN apt-get install -y git libtinfo6
RUN npm install -g --unsafe-perm purescript spago
ENV NPM_CONFIG_CACHE /mal/.npm
ENV HOME /mal
Now the build system complains that esbuild is not installed. |
Looks like that error can be resolved like this:
|
@asarhaddon I have no idea what's causing the most recent failure. I poked around a bit but didn't see anything obvious. |
See kanaka#592 for context.
50cd78b
to
7091f36
Compare
The same error appears without the merge-eval, without readline and with argv, readString, writeString from the node-process module instead of a local FFI to javascript. I am giving up the update part. |
@asarhaddon works for me. There are a lot of implementations that could/should be updated from very old version of the docker image/compiler/interpreter. I'm fine with not doing that as part of these updates if it's proves problematic. |
Hello.
These changes should be part of #592 , but