-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An Implementation in Python with a Compiler #653
Conversation
This took me a while.. and I need to redo the other operators. So far only def! and +-*/ works.
Make it verbose and more easily debuggable.
I feel the compiler should do more work, other than just delegating.
1. COMPILE now takes ast of function type. 2. Support eval and debugger toggle.
@jcguu95 If it can be restructured to fit the code layout of other implementations (https://github.com/kanaka/mal/blob/master/docs/FAQ.md#code_split) then I would be willing to consider merging it. Otherwise, if that's too complicated or unwieldy then keeping it separate is probably best. Although I would be happy to include a link to it in the top level README if you like in the "External Implementations" section. |
@kanaka Thanks for your reply! I've moved on from this project for a while, so I don't think it's likely that I'd break them into steps. It'd be nice if you could mention it in the main page. Could you please let me know when you do so? (I have renamed the project to be mal2py-compiler.) PS Thank you so much for this inspiring project. I like it a lot :) |
Hello Joel Martin! Thanks for your inspiring work! Based on your python implementation, I implemented a compiled version:
python-compile
. It passes all relevant tests (forstep2
tostepA
, regular and soft), and it is 16 times faster per the performance test suite.Would you like to merge this, or would you rather keep this maintained separately? Please let me know.
Cheers,
Jin