-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add Hare implementation #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
einsiedlerspiel
wants to merge
15
commits into
kanaka:master
Choose a base branch
from
einsiedlerspiel:hare
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2cec1c
to
c65605d
Compare
I only realised after finishing, that meta data for strings wasn't actually asked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mal implemented in pure hare https://harelang.org/ using only its standard library
There's no GC, I try to clean up any non persistent allocations but really for the most part I'm just leaking all the memory.
Metadata implementation is incomplete and only implemented for user defined functions and hashmaps, for everything else I used native types, adding meta data would probably require completely reworking that.
There's lots of things to clean up and add checks for, but I won't get to that any time soon so I thought I'll just send the PR now, before I'll never do it.
Had lot's of fun with the challenge, thanks for creating it!
Pull request requirements:
the implementation name.
Additional requirements if you are adding a new implementation (see FAQ for details):
impls/<IMPL>/Dockerfile
impls/<IMPL>/Makefile
IMPLS.yml
Makefile.impls
README.md