Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ge and le function #154

Merged
merged 2 commits into from
Dec 9, 2024
Merged

add ge and le function #154

merged 2 commits into from
Dec 9, 2024

Conversation

kannkyo
Copy link
Owner

@kannkyo kannkyo commented Dec 9, 2024

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

@kannkyo kannkyo self-assigned this Dec 9, 2024
@kannkyo kannkyo added the enhancement New feature or request label Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

flake8 results

1 files  ±0  3 suites  ±0   0s ⏱️ ±0s
1 tests  - 1  1 ✅ ±0  0 💤 ±0  0 ❌  - 1 
3 runs  ±0  3 ✅ +1  0 💤 ±0  0 ❌  - 1 

Results for commit f6ebed9. ± Comparison against base commit e11498e.

This pull request removes 1 test.
W291, trailing whitespace

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

pytest results

46 tests  +20   46 ✅ +20   5s ⏱️ +2s
 1 suites ± 0    0 💤 ± 0 
 1 files   ± 0    0 ❌ ± 0 

Results for commit f6ebed9. ± Comparison against base commit e11498e.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e11498e) to head (f6ebed9).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #154   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           53        65   +12     
=========================================
+ Hits            53        65   +12     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kannkyo kannkyo merged commit 920fd6a into main Dec 9, 2024
8 checks passed
@kannkyo kannkyo deleted the feature-add-ge-and-le branch December 11, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants