Small cleanups

[paulsheldrake]

Removes docker images that don't work on Apple Silicon
Adds a command to install a solr core on our custom solr image
Updates DB and PHP versions
Removes hardcoded values in docksal.env

[thejimbirch]

This is needed for support, but not for build.

Could we add an additional command for support? Something like fin rc which could do composer install, then fin refresh?

[paulsheldrake]

why can't we just keep this in?

[thejimbirch]

It has nothing to do with refeshing the database, and often, I will just need to reset the database, not re-install composer.

How about fin rebuild?
#111

[paulsheldrake]

I would prefer not to have a whole new command. There is no technical reason it can't be there and it makes sure when wee pull the DB we can run the site

[thejimbirch]

If I run fin init, as users should to reset their environments, composer install is run as part of init-site. Then fin refresh is run. This change you are proposing would cause composer install to run twice.

I see fin rebuild as a good compromise as it is descriptive to what it is actually doing, building composer and refreshing the database, and would fit the needs of both support and build, without changing the way fin refresh has always worked.

[paulsheldrake]

I would argue that fin refresh as it's been in the starter is inefficient. fin init should be run as minimally as possible because it's an expensive and time-consuming operation. If you run composer install in the refresh command, we just keep the code updated to date in the current branch. If there are no changes in the composer packages it's super quick, if there are changes, then you've just saved yourself the hassle of wondering why your site isn't working from missing modules. this is the way it's been in support from since we've started using docksal and composer.

we can take the composer install out of init-site and then it would just be run once during setup.

[thejimbirch]

It can't be removed from init-site as it is needed to scaffold the site for the following commands:

# Fix file/folder permissions
fix_permissions () {
  echo -e "\n${yellow} ${construction} Making file directories writable. ${construction}${NC}"
  echo -e "${green}${divider}${NC}"
  mkdir -p "${SITEDIR_PATH}/files/private"
  chmod 755 "${SITEDIR_PATH}"
  chmod 755 "${SITEDIR_PATH}/files/private"
}

# Initialize local settings files
init_settings () {
  echo -e "${yellow} ${construction} Copy settings files for local development. ${construction}${NC}"
  echo -e "${green}${divider}${NC}"
  ln -sf "${PROJECT_ROOT}/.docksal/etc/conf/settings.php" "${SITEDIR_PATH}/settings.local.php"
  ln -sf "${PROJECT_ROOT}/.docksal/etc/conf/development.services.yml" "${DOCROOT_PATH}/sites/development.services.yml"
}

And at this point, there may or may not be a database to refresh.

That is why I am suggesting a more composable approach, that the refresh command does exactly what it describes, refreshes the database. The proposed rebuild command would rebuild your composer dependencies and refresh the database.

[paulsheldrake]

when we setup the devops for the project we hook it into a hosting environment so there will always be a DB. that scenario doesn't happen

[paulsheldrake]

if you're just looking for a fresh db, there is fin pull db command which is already baked into the starter