Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: separate components in files #20

Closed
wants to merge 2 commits into from
Closed

Conversation

lajbel
Copy link
Collaborator

@lajbel lajbel commented May 22, 2024

This is a test PR, to see how it goes, but we have to have a way to have a "global" KaboomCtx, and it should be used in all files so we can separate components and call these functions.

Another approach will be simply separate all functions and only use the state "app"

  • Find a way to separate kaboom methods that depends on another kaboom methods easily

@lajbel lajbel changed the title refactor: separate componentsin files refactor: separate components in files May 22, 2024
@niceEli
Copy link
Member

niceEli commented May 22, 2024

Is this test or should merge?

@lajbel
Copy link
Collaborator Author

lajbel commented May 23, 2024

Shouldn't

@lajbel lajbel added the wip This is work in progress label May 23, 2024
@niceEli niceEli added the refactor Changes structure of the project label May 23, 2024
@amyspark-ng
Copy link
Contributor

Maybe should move components in categories because having every component in a different file feels bloating

@mflerackers
Copy link
Member

transform: pos, rotate, scale
draw: sprite, rect, circle, polygon
physics: area, body
animation: timer

@amyspark-ng
Copy link
Contributor

yes, yes

@SpcFORK
Copy link
Contributor

SpcFORK commented May 24, 2024

Find a way to separate kaboom methods that depends on another kaboom methods easily

Maybe switch to classes?
If the stack order is the issue, then using Classes will fix this

@lajbel lajbel closed this May 26, 2024
@lajbel lajbel deleted the lj-separate-health branch May 26, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes structure of the project wip This is work in progress
Projects
Status: DONE
Development

Successfully merging this pull request may close these issues.

5 participants