swap translate <--> scale transforms

[dragoncoder047]

ref: #381 (comment)

@mflerackers : "translate and scale transforms were done in the wrong order before drawing for some reason. It's an easy fix..."

is this the fix?

closes #381 if it is

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/kaplayjs/kaplay@385

commit: 1a8b712

[mflerackers]

No, certainly not. That would completely break collision detection itself.

[dragoncoder047]

No, certainly not. That would completely break collision detection itself.

So, where is the "out-of-order" transformations at?

[dragoncoder047]

This PR is empty now, but if I find the out-of order transformations I'll fix it here

[mflerackers]

Possibly here, applying the scale is done before offset. But you shouldn't only change the code, but test it as well.

worldArea(this: GameObj<AreaComp | AnchorComp>): Polygon {
const localArea = this.localArea();

        const transform = this.transform
            .clone()
            .scale(vec2(this.area.scale ?? 1))
            .translate(this.area.offset);

[dragoncoder047]

ok I tried it there

how do I re-trigger the pkg.pr.new thing so I can so I can just npm install my changes to test them? never mind, I noticed the bot updates its own comment automatically

[mflerackers]

Didn't it update itself? I think it did.

[dragoncoder047]

Didn't it update itself? I think it did.

Yeah it did (I noticed like 30 seconds after I added that comment, see the edit)

But you shouldn't only change the code, but test it as well.

I installed it and tested, it seems to work for me.

[mflerackers]

👍