Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architectural changes #10

Merged
merged 17 commits into from
Apr 21, 2024
Merged

Architectural changes #10

merged 17 commits into from
Apr 21, 2024

Conversation

kareemmahlees
Copy link
Owner

No description provided.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 84.76395% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 87.70%. Comparing base (ec4e825) to head (81348a2).

Files Patch % Lines
internal/db/pg.go 79.13% 16 Missing and 8 partials ⚠️
internal/db/mysql.go 81.41% 14 Missing and 7 partials ⚠️
internal/db/sqlite.go 84.87% 12 Missing and 6 partials ⚠️
internal/handlers/dbHandlers.go 78.57% 4 Missing and 2 partials ⚠️
internal/server.go 90.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   90.45%   87.70%   -2.76%     
==========================================
  Files          13       14       +1     
  Lines         545      724     +179     
==========================================
+ Hits          493      635     +142     
- Misses         35       60      +25     
- Partials       17       29      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

gitguardian bot commented Apr 11, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9462643 Triggered Generic Password 68f2f90 utils/testHelpers.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@kareemmahlees kareemmahlees merged commit a83c582 into master Apr 21, 2024
2 of 5 checks passed
@kareemmahlees kareemmahlees deleted the refactor_arch branch April 21, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant