Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Better Windows Support #616

Merged
merged 15 commits into from
Feb 11, 2025
Merged

feat: Better Windows Support #616

merged 15 commits into from
Feb 11, 2025

Conversation

nlogozzo
Copy link
Contributor

@nlogozzo nlogozzo commented Feb 8, 2025

  • Adds support for both raw and noritake outputs on Windows systems.
    • Supports raw_target:
      • If /dev/stdout --> stdout will be used
      • Else --> a named pipe will be created for output
  • Adds argument support for Windows CLI (i.e. -p, -h, etc...)
  • Adds loading config file from Windows home directory and with -p argument
  • Includes default config and shader files as embedded resources and writes them to disk when missing (similar to INCTXT on Linux but using native Windows resources)

@nlogozzo
Copy link
Contributor Author

nlogozzo commented Feb 9, 2025

Here's raw working:
image

@nlogozzo nlogozzo marked this pull request as draft February 9, 2025 04:53
@nlogozzo nlogozzo changed the title feat: Support raw and noritake output on Windows feat: Better Windows Support Feb 9, 2025
@nlogozzo nlogozzo marked this pull request as ready for review February 9, 2025 06:31
@nlogozzo
Copy link
Contributor Author

nlogozzo commented Feb 9, 2025

Ready for review! Sorry in advanced for my messy code, I'm a C++ dev not C dev haha. These changes will help me bring my previous linux-only app that uses cava to Windows!

Passing tests here: https://github.com/nlogozzo/cava/actions/runs/13223157589

@nlogozzo nlogozzo mentioned this pull request Feb 9, 2025
12 tasks
@karlstav
Copy link
Owner

karlstav commented Feb 9, 2025

looks ok when skimming through, I will have a closer look later to make sure nothing breaks.

@nlogozzo
Copy link
Contributor Author

nlogozzo commented Feb 9, 2025

looks ok when skimming through, I will have a closer look later to make sure nothing breaks.

Alrighty sounds good! I'm available all day to fix anything that breaks lmk

@nlogozzo
Copy link
Contributor Author

Hi, any issues?

@karlstav karlstav merged commit ea6f4ce into karlstav:master Feb 11, 2025
@karlstav
Copy link
Owner

looks good, great work!

@nlogozzo
Copy link
Contributor Author

looks good, great work!

Thanks! Happy to contribute :)

@nlogozzo
Copy link
Contributor Author

Could you release this as 0.10.4?

@karlstav
Copy link
Owner

sure why not

@nlogozzo nlogozzo deleted the win-raw branch February 11, 2025 21:19
@nlogozzo
Copy link
Contributor Author

sure why not

Thanks again!

@Dvd-Znf
Copy link

Dvd-Znf commented Feb 11, 2025

Hi!
Could you please add cava_win.zip on the 0.10.4 release like in 0.10.3?
(I want to update the microsoft/winget-pkgs package)
Many thanks!

@nlogozzo
Copy link
Contributor Author

Hi! Could you please add cava_win.zip on the 0.10.4 release like in 0.10.3? (I want to update the microsoft/winget-pkgs package) Many thanks!

^

@karlstav
Copy link
Owner

done

@Biswa96
Copy link
Contributor

Biswa96 commented Feb 21, 2025

I am building the program in visual studio. The libpthread.dll and glew.dll are not copied into cava_win\cava\x64\Debug directory. Am I missing something?

@karlstav
Copy link
Owner

@Biswa96 they are supposed to be automatically downloaded by some nuget stuff. If you still are having problems, open a separate issue, comments in here will drown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants