Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: service name and carrier name parsing #672

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: service name and carrier name parsing #672

wants to merge 2 commits into from

Commits on Sep 5, 2024

  1. fix: ensure service name and carrier consistency with other provider … 

    …packages and eShipper XML
    @jacobshilitz
    jacobshilitz committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    4a6817c View commit details
    Browse the repository at this point in the history

  2. Fix service_name fallback in rate calculation 

    Ensure `service_name` uses `rate.serviceName` as a fallback when `service.name` is not available. This prevents potential attribute errors and ensures consistent naming by replacing spaces with underscores.
    @jacobshilitz
    jacobshilitz committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    447c01c View commit details
    Browse the repository at this point in the history