Skip to content

gptel: support function values in gptel presets #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gptel: support function values in gptel presets #992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions gptel.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3820,13 +3820,15 @@ example) apply the preset buffer-locally."
(user-error "gptel preset: Cannot find directive %s" val))
(funcall setter sym val))))
(:backend
(setq val (cl-etypecase val
(setq val (if (functionp val) (funcall val) val)
val (cl-etypecase val
(gptel-backend val)
(string (gptel-get-backend val))))
(unless val
(user-error "gptel preset: Cannot find backend %s." val))
(funcall setter 'gptel-backend val))
(:tools ;TEMP Confirm this `:append' convention
(setq val (if (functionp val) (funcall val) val))
(let* ((append (when (eq (car-safe val) :append) (setq val (cdr val)) t))
(tools
(flatten-list
Expand All @@ -3845,7 +3847,7 @@ example) apply the preset buffer-locally."
(intern-soft
(concat "gptel--" (substring (symbol-name key) 1)))))
(guard (and sym (boundp sym))))
(funcall setter sym val))
(funcall setter sym (if (functionp val) (funcall val) val)))
(_ (display-warning
'(gptel presets)
(format "gptel preset: setting for %s not found, ignoring." key)))))
Expand Down