feat: Added a new param MIN_SAVED_FILE and added error handling #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The param MIN_SAVED_FILE, is used when you don't want to delete old file when you have no new files. Also, when we didn't achieve to run a copy, we no more create an empty file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if the database we wanted to back up was not accessible, we still would create a file (an empty file). It's resolved.
The other problem is that, if we can't contact database for $REMOVE_BEFORE days, we would lose all our backups ! MIN_SAVED_FILE is a new param so we keep at least $MIN_SAVED_FILE.