-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extension for file download in styles #541
base: 2.8.x-qgis_server
Are you sure you want to change the base?
Fix extension for file download in styles #541
Conversation
tested on safari, chrome and firefox. the PR in action using safari: @lucernae i've tried the content_type of @gubuntu @NyakudyaA can |
afaik Qt-QML is a completely different animal. though if it serves to add the .qml suffix maybe it is OK? |
Codecov Report
@@ Coverage Diff @@
## 2.8.x-qgis_server #541 +/- ##
=====================================================
- Coverage 41.52% 33.56% -7.96%
=====================================================
Files 412 412
Lines 29670 29670
Branches 3752 3752
=====================================================
- Hits 12319 9958 -2361
- Misses 16589 19083 +2494
+ Partials 762 629 -133
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 2.8.x-qgis_server #541 +/- ##
==================================================
Coverage 41.52% 41.52%
==================================================
Files 412 412
Lines 29670 29670
Branches 3752 3752
==================================================
Hits 12319 12319
Misses 16589 16589
Partials 762 762
Continue to review full report at Codecov.
|
@boney-bun respond and fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @boney-bun !
I think this is fairly straightforward PR.
For @gubuntu 's and @boney-bun 's comment:
The original mime type follows from QGIS definition taken here: There should be a way to force Safari to save the filename with QML extension (with mime type application/xml). This can be from Javascript file, communicated in the request header, or from
Yes, I think this is last resort though. If above suggestion still not feasible :(. |
fix #536