Add support for Unifi Network Server running remotely #65
Conversation
Task/fix auth url
Signed-off-by: aki263 <aakash@nappinggeek.com>
Signed-off-by: aki263 <aakash@nappinggeek.com>
# Conflicts: # internal/unifi/client.go
|
CC @onedr0p |
Very helpful for people who want to get started using it instead of DM-ing me.
internal/unifi/client.go
Outdated
| log.Debug("Making request", zap.String("method", method), zap.String("path", path)) | ||
|
|
||
| // Convert body to bytes for logging and reuse | ||
| var bodyBytes []byte |
There was a problem hiding this comment.
Little worried about reading the body here, I tried doing it last time and it messed up exdns
There was a problem hiding this comment.
I am not very comfortable with GO so if you think this can cause trouble, please remove it.
There was a problem hiding this comment.
I am not very comfortable with GO so if you think this can cause trouble, please remove it.
It's fine, we will test and verify it functions.
|
@aki263 Testing to ensure gateway functionality isn't impaired. Please test in your situation. |
I just tested, it works for me with env 
On unifi side 
|
|
Latest commit is working fine for me. Deleted all records and webhook recovered in less than a couple seconds. |
Added new env variable called
CONTROLLER_TYPE: NETWORK_SERVERwhich will trigger the code path that will login and update dns record on remote unifi network server. This is applicable for gateway max and lite which dont have unifi server build in.This is tested locally, test results are in #63 (comment)
I have also added lot more logging so its easier to catch errors in http requests.
Image that can be tested:
ghcr.io/aki263/external-dns-unifi-webhook:main