Tighten up P2P relay and orphan management in order to perfect high-BPS block exchange #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someone235
requested changes
Dec 15, 2023
someone235
requested changes
Dec 15, 2023
coderofstuff
requested changes
Dec 15, 2023
coderofstuff
requested changes
Dec 15, 2023
michaelsutton
changed the title
someone235
requested changes
Dec 18, 2023
michaelsutton
force-pushed
the
revalidate-orphans
branch
from
61dd275 to
2ced245
Compare
coderofstuff
approved these changes
Dec 18, 2023
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
…PS block exchange (kaspanet#359) * complete revalidate orphans correctly * improve test * names and comments * close the sync gap between consensus and the block orphan pool * renames and comments * orphan ibd heuristic * explain the ibd heuristic * simplify orphan output case + review comments * remove todo and explain why * log orphan-related events via the event logger * add nodnsseed cmd flag which disable DNS seeding for peers * bump version to 0.13.1 * updated sync gap comment * update fn doc * typo * fix logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes 3 major components which can be reviewed separately:
The end result tested via an internal TN11 testnet shows that with all the above, on-going P2P block exchange is smooth also on a 10BPS network and between peers with RTT > block time (=100ms)