Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-machete: clean-up and integration into the check workflow. #366

Closed
wants to merge 12 commits into from

Conversation

D-Stacks
Copy link
Collaborator

@D-Stacks D-Stacks commented Dec 27, 2023

This PR:

  1. Removes unused deps, as found by cargo-machete,
  2. But Keeps false positives, which where manually tested to be required for compilation
  3. Adds ignores for these false positives.
  4. Integrates cargo machete into the checks workflow in github.

Future use:

To ignore a false positive, which one thinks is erroneously flagged by cargo machete, place the deps name under [package.metadata.cargo-machete] in the corresponding Cargo.toml file.

@D-Stacks D-Stacks marked this pull request as ready for review December 27, 2023 10:23
@D-Stacks
Copy link
Collaborator Author

probably out of date by now..

@D-Stacks D-Stacks closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant