Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UTXO Return Address RPC command #436

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

coderofstuff
Copy link
Collaborator

@coderofstuff coderofstuff commented Mar 21, 2024

Specifications

Info Description
RPC Op GetUtxoReturnAddress
Input txid: Hash and accepting_block_daa_score: u64*
Output Result<Address, ReturnAddressError>**

Notes

  • *A holder of a UTXO will always know the transaction id that UTXO came from and the DAA score of the accepting block
  • **When this call finds an address, it is guaranteed that the address is from the first input of the transaction that produced your UTXO. If the algorithm cannot find a return address (there are many reasons why it might not be able to), result in a ReturnAddressError.

Proto

GetUtxoReturnAddressRequestMessage getUtxoReturnAddressRequest = 1112;
GetUtxoReturnAddressResponseMessage getUtxoReturnAddressResponse = 1113;

@coderofstuff coderofstuff force-pushed the utxo-retaddr branch 2 times, most recently from a91193a to 7d1b663 Compare March 22, 2024 05:40
@coderofstuff coderofstuff marked this pull request as ready for review March 22, 2024 05:41
Copy link
Collaborator

@D-Stacks D-Stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consensus/src/consensus/mod.rs Outdated Show resolved Hide resolved
rpc/service/src/service.rs Outdated Show resolved Hide resolved
consensus/src/consensus/mod.rs Outdated Show resolved Hide resolved
consensus/src/consensus/mod.rs Outdated Show resolved Hide resolved
rpc/core/src/api/ops.rs Outdated Show resolved Hide resolved
@KaffinPX
Copy link
Contributor

KaffinPX commented Sep 7, 2024

Could we separate accepting block finder/iterator and return address finder on consensus to possibly allow getTransactionCurrentAcceptingBlockin future to make transaction confirmation tracking simpler.

@michaelsutton michaelsutton deleted the branch kaspanet:master September 11, 2024 18:34
@michaelsutton michaelsutton reopened this Sep 11, 2024
@michaelsutton michaelsutton changed the base branch from dev to master September 11, 2024 18:44
consensus/src/consensus/mod.rs Outdated Show resolved Hide resolved
consensus/src/consensus/mod.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants