Add support for environment variable configuration, and Docker container images via ghcr #511
+151
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t docker build configuration for amd64 and arm64, and a CI pipe to build them and upload to ghcr.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a long standing issue with difficulty of deploying
kaspadin a way that makes sense in a modern datacenter. This PR adds sensible default docker container build pipelines for the most common server microarchitectures, amd64 and arm64, as well as the ability to configure kaspad with environment variables, which is generally easier in a containerized environment. arm builds are likely to be quite slow until better support for arm matrix runners is added to github runners since everything needs to happen through qemu.