Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job-builder: Add SNP job #547

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Conversation

UnmeshDeodhar
Copy link
Contributor

Adding SNP job to the job builder so that #5594 in tests can run.

Fixes: #5593

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@wainersm
Copy link
Contributor

Hi @UnmeshDeodhar ! Thanks for your PR. The jobs-builder-check has failed, meaning something is wrong with the jobs builder after your changes. Let me have a look.

@wainersm
Copy link
Contributor

Hi @UnmeshDeodhar ! Thanks for your PR. The jobs-builder-check has failed, meaning something is wrong with the jobs builder after your changes. Let me have a look.

We will need to get #549 merged first

@wainersm wainersm added the do-not-merge PR has problems or depends on another label Jun 23, 2023
@wainersm wainersm removed the do-not-merge PR has problems or depends on another label Jul 11, 2023
Adding SNP job to the job builder so that #5594 in tests can run.

Fixes: #5593

Signed-Off-By: Unmesh Deodhar <udeodhar@amd.com>
AMD SEV-SNP is supported on Milan and onwards. Thus, selecting Milan node for the SNP job.

Signed-Off-By: Unmesh Deodhar <udeodhar@amd.com>
@wainersm wainersm merged commit a0b1961 into kata-containers:main Jul 11, 2023
@wainersm wainersm mentioned this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants