Skip to content

Comments

adding integration with para#12

Open
ManyRios wants to merge 9 commits intokatana-network:mainfrom
ManyRios:para-specialk
Open

adding integration with para#12
ManyRios wants to merge 9 commits intokatana-network:mainfrom
ManyRios:para-specialk

Conversation

@ManyRios
Copy link

@ManyRios ManyRios commented Jul 14, 2025

The purpose of this PR is to show how to use PARA as an option wallet to Special K.

Para - Embedded Wallet API & SDK

@dhananjaypai08
Copy link
Contributor

Hi, thanks for the PR!
Few comments :

  • Can you change the name of the folder from para+speicialk to just para
  • Why is everything in the main root moved inside para+specialk, it is better to have a subfolder named para inside the repo (root) instead of completely trying to change the structure

@ManyRios
Copy link
Author

Hi, thanks for the PR! Few comments :

  • Can you change the name of the folder from para+speicialk to just para
  • Why is everything in the main root moved inside para+specialk, it is better to have a subfolder named para inside the repo (root) instead of completely trying to change the structure

Hi! sorry for late response... Done

Copy link
Contributor

@dhananjaypai08 dhananjaypai08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left my review, thank you for the PR
Some thoughts :

  • What is the purpose of this PR ?
  • Please include a detailed PR description of the changes
  • Solve the import errors in the repo

Copy link
Contributor

@dhananjaypai08 dhananjaypai08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, left a comment which is necessary for this merge

Copy link
Contributor

@Swader Swader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please rebase with main first, and remove files from src/utils, they are unnecessarily there (e.g. contract directory and address utils etc)

@ManyRios
Copy link
Author

Thanks! Please rebase with main first, and remove files from src/utils, they are unnecessarily there (e.g. contract directory and address utils etc)

Hi! sure I'll do this...

@ManyRios
Copy link
Author

ManyRios commented Sep 2, 2025

Just made a commit, please check when you can

@adeets-22
Copy link

Hey @dhananjaypai08 could you take a look here? Excited to get this in :)

@dhananjaypai08
Copy link
Contributor

Hey @adeets-22 and @ManyRios , currently waiting to get this pr merged in : #28
This has a build pipeline for all the examples that have react, nextjs support so that our specialk can easily fork bun projects in the UI. So will review it as soon as the above PR is merged in as that would act as the foundation for our examples/ build. Apologies for the delay

Copy link
Contributor

@dhananjaypai08 dhananjaypai08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! @ManyRios I have left some thoughts
Could you also merge the recent main branch into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants