Skip to content

Commit

Permalink
Merge branch 'master' into prepare-release
Browse files Browse the repository at this point in the history
  • Loading branch information
katranci authored Oct 22, 2017
2 parents a9385e2 + 06c9f67 commit 2093195
Showing 2 changed files with 19 additions and 0 deletions.
15 changes: 15 additions & 0 deletions src/get-package-name/__tests__/fetch-package-name.test.js
Original file line number Diff line number Diff line change
@@ -68,6 +68,21 @@ describe('fetchPackageName', () => {
expect(console.warn).toHaveBeenCalledWith('[github-npm-stats] Error: Hourly GitHub api rate limit exceeded')
})

it('returns N/A if name is absent from package.json', async () => {
fetch.mockImplementation((url) => {
return Promise.resolve({
json: () => Promise.resolve(apiResponse({
packageJson: {
name: undefined
}
}))
})
})

const packageName = await fetchPackageName('vuejs', 'vue')
expect(packageName).toBe('N/A')
})

describe('if package is private', () => {
beforeEach(() => {
fetch.mockImplementation((url) => {
4 changes: 4 additions & 0 deletions src/get-package-name/fetch-package-name.js
Original file line number Diff line number Diff line change
@@ -16,6 +16,10 @@ const fetchPackageName = async (owner, repo) => {
const packageJson = JSON.parse(atob(responseBody.content))
let packageName = packageJson.name

if (!packageName) {
return 'N/A'
}

if (packageJson.private) {
packageName = await resolvePrivatePackage(owner, repo, packageName)
}

0 comments on commit 2093195

Please sign in to comment.