Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Regions] fix region dragging on played-over area #3371

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Conversation

katspaugh
Copy link
Owner

Short description

Resolves #3296

Clip-path was introduced in #3285 as a visual improvement but it broke region dragging past the progress line.

Implementation details

Instead of listening to mouse events on the canvases container, avoid the clip-path by listening to them on the wrapper container.

@katspaugh katspaugh changed the title Fix: [Regions] rm clip-path to enable region dragging on progress canvas Fix: [Regions] fix region dragging on played-over area Dec 3, 2023
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1a7d400
Status: ✅  Deploy successful!
Preview URL: https://14481958.wavesurfer-js.pages.dev
Branch Preview URL: https://fix-clip.wavesurfer-js.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Dec 3, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh merged commit b31516c into main Dec 3, 2023
4 checks passed
@katspaugh katspaugh deleted the fix-clip branch December 3, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regions] Creating regions by dragging doesn't work with clip-path
1 participant