Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix virtual env path environment variable in Dockerfile #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix virtual env path environment variable in Dockerfile #46

wants to merge 1 commit into from

Conversation

rominf
Copy link

@rominf rominf commented Jun 27, 2024 •
edited
Loading

Currently, docker build fails because pip is not found:

$ podman-compose  -f docker-compose.dev.yml  -f docker-compose.yml --podman-build-args="--security-opt label=disable" up --build --build-arg INSTALL_DEV_DEPS=0 --build-arg BUILD_ID=0
[3/4] STEP 13/13: RUN --mount=type=cache,target=${XDG_CACHE_HOME}/pip     if [ ! -z "${INSTALL_DEV_DEPS}" ] ; then ${VENV_PATH}/bin/pip install -r ${app_path}/requirements-dev.txt ; fi
/bin/sh: 1: /bin/pip: not found
Error: building at STEP "RUN --mount=type=cache,target=${XDG_CACHE_HOME}/pip if [ ! -z "${INSTALL_DEV_DEPS}" ] ; then ${VENV_PATH}/bin/pip install -r ${app_path}/requirements-dev.txt ; fi": while running runtime: exit status 127

The reason for this is that VENV_PATH is defined below it is used. The change leverages that VIRTUAL_ENV is already defined, and the fact that:

A stage inherits any environment variables that were set using ENV by its parent stage or any ancestor.

(see: https://docs.docker.com/reference/dockerfile/#env)

The line with PATH is deleted because it is unnecessary because of the
same fact.

Note that I ran podman-compose because Fedora comes with podman, not docker, yet here the behavior of podman and docker are identical.

@rominf
Fix virtual env path environment variable in Dockerfile
1e3021e 
Currently, docker build fails because `pip` is not found:
```
$ podman-compose  -f docker-compose.dev.yml  -f docker-compose.yml --podman-build-args="--security-opt label=disable" up --build --build-arg INSTALL_DEV_DEPS=0 --build-arg BUILD_ID=0
...
[3/4] STEP 13/13: RUN --mount=type=cache,target=${XDG_CACHE_HOME}/pip     if [ ! -z "${INSTALL_DEV_DEPS}" ] ; then ${VENV_PATH}/bin/pip install -r ${app_path}/requirements-dev.txt ; fi
/bin/sh: 1: /bin/pip: not found
Error: building at STEP "RUN --mount=type=cache,target=${XDG_CACHE_HOME}/pip if [ ! -z "${INSTALL_DEV_DEPS}" ] ; then ${VENV_PATH}/bin/pip install -r ${app_path}/requirements-dev.txt ; fi": while running runtime: exit status 127
```

The reason for this is that `VENV_PATH` is defined below it is used. The
change leverages that `VIRTUAL_ENV` is already defined, and the fact that:

> A stage inherits any environment variables that were set using ENV by
> its parent stage or any ancestor.

(see: https://docs.docker.com/reference/dockerfile/#env)

The line with `PATH` is deleted because it is unnecessary because of the
same fact.

Note that I ran `podman-compose` because Fedora comes with `podman`, not
`docker`, yet here the behavior of `podman` and `docker` are identical.
@rominf rominf force-pushed the rominf-dockerfile-pip branch from e58e36b to 1e3021e Compare June 27, 2024 16:13
@rominf rominf marked this pull request as ready for review June 27, 2024 16:14
rominf added a commit to rominf/kausal-paths that referenced this pull request Jun 27, 2024
@rominf
Fix Dockerfile ARG scope
87df7f9 
After applying changes from
kausaltech#46, Docker does not
build still.

```
$ podman-compose  -f docker-compose.dev.yml  -f docker-compose.yml --podman-build-args="--security-opt label=disable" up --build --build-arg INSTALL_DEV_DEPS=0 --build-arg BUILD_ID=0
[4/4] STEP 15/32: RUN groupadd -g ${app_user_gid} user && useradd --no-log-init -m -d /home/user -g ${app_user_gid} -u ${app_user_uid} -r user
groupadd: invalid group ID 'user'
Error: building at STEP "RUN groupadd -g ${app_user_gid} user && useradd --no-log-init -m -d /home/user -g ${app_user_gid} -u ${app_user_uid} -r user": while running runtime: exit status 3
```

The reason is incorrect scope for multiple `ARG`s:

> An ARG instruction goes out of scope at the end of the build stage
> where it was defined. To use an argument in multiple stages, each stage
> must include the ARG instruction.

(see: https://docs.docker.com/reference/dockerfile/#scope)

The change fixes the scope for all `ARG`s.

Note that I ran `podman-compose` because Fedora comes with `podman`, not
`docker`, yet here the behavior of `podman` and `docker` are identical.
@rominf rominf mentioned this pull request Jun 27, 2024
Open
rominf added a commit to rominf/kausal-paths that referenced this pull request Jun 27, 2024
@rominf
Fix Docker ARG scope
650a0c6 
After applying changes from
kausaltech#46, Docker does not
build still.

```
$ podman-compose  -f docker-compose.dev.yml  -f docker-compose.yml --podman-build-args="--security-opt label=disable" up --build --build-arg INSTALL_DEV_DEPS=0 --build-arg BUILD_ID=0
[4/4] STEP 15/32: RUN groupadd -g ${app_user_gid} user && useradd --no-log-init -m -d /home/user -g ${app_user_gid} -u ${app_user_uid} -r user
groupadd: invalid group ID 'user'
Error: building at STEP "RUN groupadd -g ${app_user_gid} user && useradd --no-log-init -m -d /home/user -g ${app_user_gid} -u ${app_user_uid} -r user": while running runtime: exit status 3
```

The reason is incorrect scope for multiple `ARG`s:

> An ARG instruction goes out of scope at the end of the build stage
> where it was defined. To use an argument in multiple stages, each stage
> must include the ARG instruction.

(see: https://docs.docker.com/reference/dockerfile/#scope)

The change fixes the scope for all `ARG`s, so that build succeeds.

Note that I ran `podman-compose` because Fedora comes with `podman`, not
`docker`, yet here the behavior of `podman` and `docker` are identical.
rominf added a commit to rominf/kausal-paths that referenced this pull request Jun 27, 2024
@rominf
Fix Dockerfile permission issues
f5b5816 
On docker build after changes from:
kausaltech#46
and
kausaltech#47
I am getting:
```
$ podman-compose  -f docker-compose.dev.yml  -f docker-compose.yml --podman-build-args="--security-opt label=disable" up --build --build-arg INSTALL_DEV_DEPS=0 --build-arg BUILD_ID=0
...
Execution of msgfmt failed: msgfmt: error while opening "/venv/lib/python3.12/site-packages/django_filters/locale/fi/LC_MESSAGES/django.mo" for writing: Permission denied
...
CommandError: compilemessages generated one or more errors.
```

The change fixes permission errors by adding required dirs to `chown -R`
call.

After this build finally succeeds.

Note that I ran `podman-compose` because Fedora comes with `podman`, not
`docker`, yet here the behavior of `podman` and `docker` are identical.
@rominf rominf mentioned this pull request Jun 27, 2024
Open
rominf added a commit to rominf/kausal-paths that referenced this pull request Jun 27, 2024
@rominf
Fix Dockerfile permission issues
c752f47 
On docker build after changes from:
kausaltech#46
and
kausaltech#47
there is a build error still:
```
$ podman-compose  -f docker-compose.dev.yml  -f docker-compose.yml --podman-build-args="--security-opt label=disable" up --build --build-arg INSTALL_DEV_DEPS=0 --build-arg BUILD_ID=0
...
Execution of msgfmt failed: msgfmt: error while opening "/venv/lib/python3.12/site-packages/django_filters/locale/fi/LC_MESSAGES/django.mo" for writing: Permission denied
...
CommandError: compilemessages generated one or more errors.
```

The change fixes permission errors by adding required dirs to `chown -R`
call.

After this build finally succeeds.

Note that I ran `podman-compose` because Fedora comes with `podman`, not
`docker`, yet here the behavior of `podman` and `docker` are identical.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rominf