fix: use sha256, apply sc_reduce32 and change salt in key derivation
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detherminal
changed the title
sc_reduce32 and change salt in key derivation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Sha3_256toSha256and make necessary changes to salt.Take a look at Cake Wallet's polyseed implementation in Dart:
https://github.com/cake-tech/polyseed_dart/blob/cc3092ef0289c45520a098becb2ee8fb25adf50f/lib/src/polyseed.dart#L174-L195
We also need to add coin index to the 17th byte of salt but it is not necessary as this crate is only for Monero.
EDIT (25.02.2025):
Also added applying
sc_reduce32instead of direct convertion. Direct version gives error even if the entropy is correct.