Enhance the global object #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `ScriptOutputChannelName` in `Strings.Designer.cs` and `Strings.resx`. - Added property `ScriptOutputChannelName` in `Strings.Designer.cs`. - Added entry for `ScriptOutputChannelName` in `Strings.resx` with value "VSExtension1 Script".
- Made GlobalObject class public and added XML documentation. - Updated constructor to accept IServiceProvider. - Added using directives for various Microsoft namespaces. - Introduced properties for JoinableTaskFactory and VisualStudioExtensibility. - Added private readonly field _outputChannel, initialized asynchronously. - Added public property Output to provide TextWriter for scripts.
Introduce AGPL-3.0 license notice in ExtensionEntrypoint.cs. Handle null directory in CreateScriptEngine with default ".". Create GlobalObject using serviceProvider directly. Update ExtensionConfiguration publisherName to "Kaz Nishimura".
Added a line of code to the `__init__.js` file that writes "Hello from __init__.js" to the output using the `extension.Output.WriteLine` method. This change helps confirm that the initialization script is executed correctly.
The GlobalObject instantiation has been moved outside of the try block to ensure it is created before any potential exceptions are caught. This change allows the globalObject to be used in the catch blocks. Specifically, the ScriptEngineException catch block now writes the exception message to globalObject.Output instead of having a TODO comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Classification
Code enhancement and documentation update.
PR Summary
This pull request enhances the
ExtensionEntrypoint.csandGlobalObject.csfiles with improved error handling, documentation, and new properties, along with adding a new localized string.ExtensionEntrypoint.cs: Added copyright notice, handled potential nullbasePath, replacedextensibilitywithglobalObject, and updatedpublisherName.GlobalObject.cs: Made class public, added documentation comments, introduced and initialized new properties.Strings.Designer.csandStrings.resx: Added new localized stringScriptOutputChannelName.__init__.js: Updated to write a message to the output channel.