This repository has been archived by the owner on Jan 13, 2024. It is now read-only.
Add patch for NaN, Inf compiler errors, quality-of-life improvement in WhatIsNpp #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhatIsNpp previously continued writing text slowly even if the user switched files during the writing. This led to annoying addition of text to existing files with no way to stop it other than closing Notepad++. Now simply switching files will terminate this process.
MAJOR ADDITIONS Some issue (probably associated with IlMerge and more indirectly with [ildasm.exe](https://developercommunity.visualstudio.com/t/ildasmexe-regression-with-infinum-floating-point-v/545431) causes compiler errors whenever you use double.NegativeInfinity, double.PositiveInfinity, or double.NaN. You can use NanInf.neginf, NanInf.inf, and NanInf.nan instead. They're just generated at runtime. MINOR CHANGES Change the callbackWhatIsNpp function so that it prints text a little more quickly, and also stops printing text if the active file changes. That way it doesn't keep typing into existing files when you don't want it to.
Previously the GetFilePath method of NotepadPPGateway was unusable in 64-bit Notepad++ because it accepted an int parameter, but the buffer id (the IdFrom parameter of the NPPN_FILEBEFORECLOSE notification) could be 64-bit. Also added a new plugin command to Demo.cs illustrating how tracking the NPPN_FILEBEFORECLOSE notification allows the plugin to keep a list of all the filenames that were closed this session.
|
I'm going to close this PR and reopen with just the NanInf.cs addition. This should make my changes easier to review and merge. I will also create a PR with just the int->IntPtr change in GetFilePath. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in issue #93, some dependency in the project causes compiler errors if the compiler sees
double.Infinity,double.NegativeInfinity,double.NaN, or anything else like1d / 0dthat can be compiled to one of those via static analysis.The NanInf class would solve that simply by safely creating those at runtime. I added a menu command with information on these errors and how to use the class. It's a crude and inelegant solution, but it works.
I also replaced insertCurrentPath with getCurrentPath, so you can get the current absolute file path as a string. I used this to periodically check the active file in whatIsNpp so that changing the active file stops the printing of text.
I changed the argument type for
NotepadPPGateway.GetFilePathfrominttoIntPtrto ensure that it can handle the 64-bit buffer ID's made by 64-bit Notepad++, and also added a new plugin command,Show files closed this session, to illustrate how this method can be used to register the name of a file when it's closed (since the user might close a file other than the currently open file).I flagged IScintillaGateway.SetLexerLanguage as not working and indicated that people should use INotepadPPGateway.SetCurrentLanguage instead.
Nothing groundbreaking, but I think it's probably good to have.