fix: fix logWriter missing in KpmClient

Signed-off-by: zongz <zongzhe1024@163.com>
kcl-lang · Apr 29, 2024 · 108ecaf · 108ecaf
1 parent f3e75d9
commit 108ecaf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/pkg/client/client.go b/pkg/client/client.go
@@ -380,6 +380,7 @@ func (c *KpmClient) CompileWithOpts(opts *opt.CompileOptions) (*kcl.KCLResultLis
 	}
 
 	c.noSumCheck = opts.NoSumCheck()
+	c.logWriter = opts.LogWriter()
 
 	kclPkg, err := c.LoadPkgFromPath(pkgPath)
 	if err != nil {

diff --git a/pkg/client/client_test.go b/pkg/client/client_test.go
@@ -1480,12 +1480,16 @@ func TestRunWithOciDownloader(t *testing.T) {
 
 	kpmCli.DepDownloader = downloader.NewOciDownloader("linux/amd64")
 
+	var buf bytes.Buffer
+	writer := io.MultiWriter(&buf, os.Stdout)
+
 	res, err := kpmCli.RunWithOpts(
 		opt.WithEntries([]string{filepath.Join(path, "run_pkg", "pkg", "main.k")}),
 		opt.WithKclOption(kcl.WithWorkDir(filepath.Join(path, "run_pkg", "pkg"))),
 		opt.WithNoSumCheck(true),
-		opt.WithLogWriter(nil),
+		opt.WithLogWriter(writer),
 	)
 	assert.Equal(t, err, nil)
+	assert.Equal(t, buf.String(), "downloading 'zong-zhe/helloworld:0.0.3' from 'ghcr.io/zong-zhe/helloworld:0.0.3'\n")
 	assert.Equal(t, res.GetRawYamlResult(), "The_first_kcl_program: Hello World!")
 }