Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kcl.mod package.edition with the kcl compiler version #250

Conversation

AkashKumar7902
Copy link
Contributor

@AkashKumar7902 AkashKumar7902 commented Jan 23, 2024

Solves: #186

Signed-off-by: Akash Kumar meakash7902@gmail.com

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Copy link

github-actions bot commented Jan 23, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@AkashKumar7902
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@coveralls
Copy link

coveralls commented Jan 23, 2024

Pull Request Test Coverage Report for Build 7947134242

Details

  • -8 of 10 (20.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 40.863%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/client/client.go 2 4 50.0%
pkg/package/package.go 0 3 0.0%
pkg/runner/runner.go 0 3 0.0%
Totals Coverage Status
Change from base Build 7946689595: -0.05%
Covered Lines: 1666
Relevant Lines: 4077

💛 - Coveralls

Peefy added a commit to kcl-lang/cla.db that referenced this pull request Jan 23, 2024
@Peefy Peefy requested a review from zong-zhe January 24, 2024 02:02
@AkashKumar7902
Copy link
Contributor Author

@zong-zhe Please take a look!

pkg/client/client.go Outdated Show resolved Hide resolved
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
@AkashKumar7902
Copy link
Contributor Author

AkashKumar7902 commented Feb 18, 2024

@Peefy can you please rerun "unit test" pipeline ? looks like a flaky github action run as all the unit tests are passing in my desktop

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
@AkashKumar7902 AkashKumar7902 force-pushed the enhancement-check-kcl-version-update-kcl.mod branch from 4ff8af0 to af84cde Compare February 20, 2024 15:01
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit e0807e1 into kcl-lang:main Feb 20, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants