[WIP] added check between pkg version and git tag for consistency #254
Conversation
Signed-off-by: Abhishek Kumar <abhishek22512@gmail.com>
Pull Request Test Coverage Report for Build 7651824560
💛 - Coveralls |
| @@ -257,3 +266,13 @@ func parseOciPkgNameAndVersion(s string) (string, string, error) { | |||
|
|
|||
| return parts[0], parts[1], nil | |||
| } | |||
|
|
|||
| func checkGitTagConsistency(kclPkg *pkg.KclPkg, gitTag string) *reporter.KpmEvent { | |||
There was a problem hiding this comment.
What needs to be checked here is whether the version of the package is consistent with the version of the remote package.
There was a problem hiding this comment.
kclPkg.GetPkgVersion() will give the package version and gitTag consists of the remote version, right. Am I missing something here?
There was a problem hiding this comment.
I believe this issue should display both the git tag/commit/branch information and the module version information in the kcl.mod file, e.g., k8s = {git = "xxx", tag = "yyy", version = "zzz"}, rather than just checking for inconsistency.
|
Hi @octonawish-akcodes 😄 The issue corresponding to this PR is re-established to #266, and a more detailed design is provided. You can refer to #266 to adjust your PR. If you have any difficulties or don't understand anything, let me know 😄 |
zong-zhe
changed the title
1. Does this PR affect any open issues?(Y/N)
fix #190
2. What is the scope of this PR (e.g. component or file name):
pkg/cmd/cmd_add.go
Tried to implement a check @Peefy @zong-zhe