Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added contribution guideline link in README #260

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Added contribution guideline link in README #260

merged 1 commit into from
Feb 18, 2024

Conversation

atarax665
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

README.md

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link

github-actions bot commented Feb 1, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@atarax665
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Peefy added a commit to kcl-lang/cla.db that referenced this pull request Feb 1, 2024
@Peefy
Copy link
Contributor

Peefy commented Feb 1, 2024

I have read the CLA Document and I hereby sign the CLA

Hello @atarax665, thank your for contribution! Pls sign the DCO.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7740141308

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.632%

Totals Coverage Status
Change from base Build 7726301670: 0.0%
Covered Lines: 1594
Relevant Lines: 3923

💛 - Coveralls

@zong-zhe
Copy link
Contributor

zong-zhe commented Feb 5, 2024

Hi @atarax665 😊

Thanks for your contribution 👍. You can adjust your commit message using git commit --amend -s

More details - https://github.com/apps/dco

@zong-zhe
Copy link
Contributor

Hi @atarax665 😄
Thanks for your contribution. You need to sign the DCO by git commit -s, signing this document not only protects your rights, but also ensures our cooperation is smoother and more transparent

@Peefy Peefy merged commit 296b6ed into kcl-lang:main Feb 18, 2024
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Contributing.md Enhancement: kpm add command displaying optimization
4 participants