Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Construction : kcl mod graph to show the dependency graph of KCL package #265

Merged
merged 12 commits into from
Feb 20, 2024

Conversation

Vanshikav123
Copy link
Contributor

@Vanshikav123 Vanshikav123 commented Feb 13, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

pkg/client.go
pkg/client/dependency_graph.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: Vanshika <vanshikav928@gmail.com>
Copy link

github-actions bot commented Feb 13, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Vanshikav123 Vanshikav123 changed the title pretest [LFX PreTest] : kcl mod graph to show the dependency graph of KCL package Feb 13, 2024
@Vanshikav123
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Vanshikav123
Copy link
Contributor Author

recheck

Peefy added a commit to kcl-lang/cla.db that referenced this pull request Feb 13, 2024
@Vanshikav123 Vanshikav123 changed the title [LFX PreTest] : kcl mod graph to show the dependency graph of KCL package Graph Construction : kcl mod graph to show the dependency graph of KCL package Feb 13, 2024
Signed-off-by: Vanshika <vanshikav928@gmail.com>
@coveralls
Copy link

coveralls commented Feb 14, 2024

Pull Request Test Coverage Report for Build 7969235992

Details

  • -54 of 81 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 40.839%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/client/client.go 27 33 81.82%
pkg/client/dependency_graph.go 0 48 0.0%
Totals Coverage Status
Change from base Build 7946689595: -0.08%
Covered Lines: 1694
Relevant Lines: 4148

💛 - Coveralls

pkg/client/client.go Outdated Show resolved Hide resolved
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Vanshika <vanshikav928@gmail.com>
pkg/client/client.go Outdated Show resolved Hide resolved
Vanshikav123 and others added 2 commits February 18, 2024 11:58
Signed-off-by: Vanshika <vanshikav928@gmail.com>
pkg/client/client.go Outdated Show resolved Hide resolved
pkg/client/client.go Outdated Show resolved Hide resolved
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Vanshika <vanshikav928@gmail.com>
pkg/client/client_test.go Show resolved Hide resolved
pkg/client/dependency_graph.go Show resolved Hide resolved
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -157,6 +157,43 @@ func TestDependencyGraph(t *testing.T) {
)
}

func TestParseKclModFile(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please fix the failed test cases?
image
After the CI passed, I will merge this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaa.... Sure will do it ASAP

Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Vanshika <vanshikav928@gmail.com>
@Peefy Peefy merged commit b6d5a18 into kcl-lang:main Feb 20, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants