fix: report in case of cyclic dependency #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Pull Request Test Coverage Report for Build 7975423704Details
💛 - Coveralls |
Peefy
reviewed
Feb 19, 2024
| @@ -157,6 +157,10 @@ func TestDependencyGraph(t *testing.T) { | |||
| ) | |||
| } | |||
|
|
|||
| func TestCyclicDependency(t *testing.T) { | |||
There was a problem hiding this comment.
The test is empty and CI failed.
There was a problem hiding this comment.
yeah i am working on that test. this test wasn't supposed to be pushed, got committed with other changes on client_test.go
sorry about that
There was a problem hiding this comment.
@Peefy I have added the unit test, i couldn't understand why "windows test" ci is failing.
any insights what went wrong ?
also e2e tests are failing as cycle exist and now an error is thrown.
I can fix the e2e test by changing test_suite.stdout files
AkashKumar7902
force-pushed
the
report-when-dependency-graph-contains-cycle
branch
5 times, most recently
from
9292e22 to
0bb5900
Compare
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
AkashKumar7902
force-pushed
the
report-when-dependency-graph-contains-cycle
branch
from
0bb5900 to
8c49378
Compare
AkashKumar7902
commented
Feb 19, 2024
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Peefy
reviewed
Feb 19, 2024
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
AkashKumar7902
force-pushed
the
report-when-dependency-graph-contains-cycle
branch
3 times, most recently
from
bf125fb to
fbbf056
Compare
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
AkashKumar7902
force-pushed
the
report-when-dependency-graph-contains-cycle
branch
from
fbbf056 to
d3eb344
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
fix #267
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: