Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix symlink bug on windows #274

Merged
merged 2 commits into from
Feb 28, 2024
Merged

fix: fix symlink bug on windows #274

merged 2 commits into from
Feb 28, 2024

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re KusionStack/kusion#831

2. What is the scope of this PR (e.g. component or file name):

use the dircopy instead symlink on windows

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added the bug Something isn't working label Feb 28, 2024
@zong-zhe zong-zhe requested a review from Peefy February 28, 2024 14:16
@zong-zhe zong-zhe self-assigned this Feb 28, 2024
Signed-off-by: zongz <zongzhe1024@163.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8082021232

Details

  • -1 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 40.995%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/client/client.go 7 8 87.5%
Totals Coverage Status
Change from base Build 8074606243: 0.06%
Covered Lines: 1705
Relevant Lines: 4159

💛 - Coveralls

@Peefy Peefy merged commit 2dd4120 into kcl-lang:main Feb 28, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants