Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supports dependencies with oci url in kcl.mod #284

Closed
wants to merge 44 commits into from
Closed

feat: supports dependencies with oci url in kcl.mod #284

wants to merge 44 commits into from

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label Mar 25, 2024
@zong-zhe zong-zhe requested a review from Peefy March 25, 2024 09:36
@zong-zhe zong-zhe self-assigned this Mar 25, 2024
Copy link

github-actions bot commented Mar 25, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


5 out of 6 committers have signed the CLA.
@Vanshikav123
@AkashKumar7902
@octonawish-akcodes
@zong-zhe
@liangyuanpeng
@adohe
You can retrigger this bot by commenting recheck in this Pull Request

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8417987133

Details

  • 100 of 226 (44.25%) changed or added relevant lines in 6 files are covered.
  • 32 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 41.573%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/package/modfile.go 28 35 80.0%
pkg/package/toml.go 30 37 81.08%
pkg/client/client.go 34 55 61.82%
pkg/utils/utils.go 0 43 0.0%
pkg/package/package.go 1 49 2.04%
Files with Coverage Reduction New Missed Lines %
pkg/client/client.go 32 55.96%
Totals Coverage Status
Change from base Build 8374936982: 0.1%
Covered Lines: 1818
Relevant Lines: 4373

💛 - Coveralls

Vanshikav123 and others added 25 commits March 25, 2024 17:40
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Vanshika <vanshikav928@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek22512@gmail.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
zong-zhe and others added 19 commits March 25, 2024 17:41
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: Lan Liang <gcslyp@gmail.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed off by: fossabot <badges@fossa.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe closed this Mar 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
8 participants