Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make some function deprecated #293

Closed
wants to merge 2 commits into from
Closed

feat: make some function deprecated #293

wants to merge 2 commits into from

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added the enhancement New feature or request label Mar 29, 2024
@zong-zhe zong-zhe requested a review from Peefy March 29, 2024 03:54
@zong-zhe zong-zhe self-assigned this Mar 29, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8476961753

Details

  • 30 of 64 (46.88%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 43.257%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd_add.go 0 1 0.0%
pkg/cmd/cmd_pkg.go 0 1 0.0%
pkg/api/kpm_pkg.go 3 5 60.0%
pkg/cmd/cmd_graph.go 0 2 0.0%
pkg/cmd/cmd_push.go 0 2 0.0%
pkg/client/client.go 26 52 50.0%
Totals Coverage Status
Change from base Build 8467230085: 0.4%
Covered Lines: 1931
Relevant Lines: 4464

💛 - Coveralls

@Peefy
Copy link
Contributor

Peefy commented Mar 29, 2024

I have some suggestions for this PR

  • Write clearly what are the current issues with the API, goals and non-goals
  • How to connect different APIs in user scenarios, i.e. demand and user stories
  • What APIs do we need to provide for the problems and requirements, what are the levels of APIs, how to distinguish their names, and some specific prompts
    • How to distinguish whether to instantiate kpm client
    • How to distinguish the APIs of kpm and kcl-go
    • Can I directly obtain the usage of the API based on its name

@zong-zhe zong-zhe closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants