Downloader pattern #355
Closed
Downloader pattern #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: d4v1d03 <a_pandey1@ce.iitr.ac.in>
Signed-off-by: d4v1d03 <a_pandey1@ce.iitr.ac.in>
Signed-off-by: d4v1d03 <a_pandey1@ce.iitr.ac.in>
Signed-off-by: d4v1d03 <a_pandey1@ce.iitr.ac.in>
Signed-off-by: d4v1d03 <a_pandey1@ce.iitr.ac.in>
Signed-off-by: d4v1d03 <amit08072005@gmail.com>
Signed-off-by: d4v1d03 <amit08072005@gmail.com>
Signed-off-by: d4v1d03 <amit08072005@gmail.com>
This reverts commit 78e34fc.
Signed-off-by: d4v1d03 <amit08072005@gmail.com>
|
Hi @d4v1d03 The test case isn't passing and it looks like 
|
Signed-off-by: d4v1d03 <amit08072005@gmail.com>
Peefy
reviewed
May 31, 2024
| @@ -918,7 +918,7 @@ func (c *KpmClient) AcquireTheLatestOciVersion(ociSource pkg.Oci) (string, error | |||
| // Download will download the dependency to the local path. | |||
| func (c *KpmClient) Download(dep *pkg.Dependency, homePath, localPath string) (*pkg.Dependency, error) { | |||
| if dep.Source.Git != nil { | |||
| err := c.DepDownloader.Download(*downloader.NewDownloadOptions( | |||
| err := c.DepDownloader.Download(*downloader.NewDownloadOptions( | |||
Peefy
reviewed
May 31, 2024
pkg/downloader/downloader_test.go
Outdated
| func TestOciDownloader(t *testing.T) { | ||
| path_oci := getTestDir("test_oci") | ||
| if err := os.MkdirAll(path_oci, os.ModePerm); err != nil { | ||
| ociTestDir := getTestDir("oci_test_dir") |
There was a problem hiding this comment.
The purpose of the issue is to complete the GitDownloader. Please do not modify the content related to OCI Downloader.
zong-zhe
reviewed
Jun 3, 2024
pkg/downloader/downloader_test.go
Outdated
| t.Fatal(err) | ||
| } | ||
|
|
||
| defer func() { | ||
| _ = os.RemoveAll(path_git) | ||
| _ = os.RemoveAll(gitTestDir) | ||
| }() | ||
|
|
||
| gitDownloader := GitDownloader{} |
There was a problem hiding this comment.
Separate this test case for GitDownloader and do not write it together with TestOciDownloader for OciDownloader
There was a problem hiding this comment.
@zong-zhe , done the same, don't know why there's a timeout occuring for my TestGitDownloader() function, can you please have a look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: