make initializer and terminator workspace URLs distinguishable #3707
+126
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
size/L
olamilekan000
requested review from
SimonTheLeg
and removed request for
embik
kcp-ci-bot
added
the
kind/api-change
olamilekan000
force-pushed
the
differentiate-btw-terminator-and-intializer
branch
2 times, most recently
from
9600d2a to
8025026
Compare
Contributor
Author
|
/retest |
Member
|
Thanks for the contribution! This looks solid, would need to take an in-depth look, but I'll put a hold on it because we are very close to the 0.29.0 release and I wouldn't want to change APIs right now. After the release is out, we can merge this. /hold |
kcp-ci-bot
added
the
do-not-merge/hold
cnvergence
reviewed
Nov 10, 2025
pkg/reconciler/tenancy/workspacetype/workspacetype_controller_reconcile.go
Outdated
Show resolved
Hide resolved
cnvergence
reviewed
Nov 10, 2025
pkg/reconciler/tenancy/workspacetype/workspacetype_controller_reconcile.go
Outdated
Show resolved
Hide resolved
Signed-off-by: olalekan odukoya <odukoyaonline@gmail.com>
olamilekan000
force-pushed
the
differentiate-btw-terminator-and-intializer
branch
from
8025026 to
0cab942
Compare
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes 3699
Release Notes