feat: implement alternating line colors a la taskwarrior#702
Open
jakebox wants to merge 1 commit intokdheepak:mainfrom
Open
feat: implement alternating line colors a la taskwarrior#702jakebox wants to merge 1 commit intokdheepak:mainfrom
jakebox wants to merge 1 commit intokdheepak:mainfrom
Conversation
Applies `color.alternate` on alternating lines like taskwarrior does.
jakebox
force-pushed
the
jb/alternating-colors
branch
from
5195d45 to
06b2658
Compare
kdheepak
reviewed
Mar 29, 2026
| let style = self.style_for_task(&self.tasks[i]); | ||
| // Apply alternating row color as base style for odd rows | ||
| let base_style = if i % 2 == 1 { | ||
| self.config.color.get("color.alternate").copied().unwrap_or_default() |
Owner
There was a problem hiding this comment.
Can we get the self.config.color.get("color.alternate") outside of the for loop?
Owner
|
Thank you for the PR! I think early on I didn't do this because mixing colors for tagged lines or selected line with alternate colors didn't look good. But I think now, it would be nice to have the feature gated behind a taskwarrior-tui option to disable it (so enabled by default). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tweak applies
color.alternateon alternating lines liketaskwarriordoes.I do wonder if there was a reason this was not implemented previously. Should this be separately configurable from taskwarrior? I figure if users want to configure it they can, however it will apply to both the TUI and regular.